JupyterLab 4 support #397
JupyterLab 4 support #397
Conversation
|
CI failures are unrelated: #398 |
martinRenou
force-pushed
the
jlab4
branch
2 times, most recently
from
954fd7d to
0de3dce
Compare
|
Having lumino packages be shared should be default by the JLab extension compilation process, IIRC: https://github.com/jupyterlab/jupyterlab/blob/cb26f15084af61ec112c46c0246f4e0118be5f2b/builder/src/extensionConfig.ts#L100-L107 If this isn't happening, there's something wrong with the lab extension build process, I think. |
|
Indeed, though it seems that ipydatagrid falls into a case where it's not. I'm not understanding exactly why. |
Signed-off-by: martinRenou <martin.renou@gmail.com>
This rule was only applying to the old Phosphor grid, it now applies to both the Phosphor and the Lumino grid Signed-off-by: martinRenou <martin.renou@gmail.com>
This is supposed to by a dependency (already one), not a dev dependency Signed-off-by: martinRenou <martin.renou@gmail.com>
I will try to find time to look deeper into the JupyterLab builder to see what could go wrong. In the meantime, this looks like a fine workaround. |
That sounds like a potentially big thing to solve in JLab. Does a test example extension from the jlab extension cookiecutter have this issue, or is it specific to ipywidgets extensions? |
When installing JupyterLab 4 (
pip install jupyterlab==4.0.0a33) ipydatagrid would not work. The issue seems to be due to ipydatagrid shipping its own version of Lumino v1 in this case, which is incompatible with JupyterLab 4 which uses Lumino v2. Setting Lumino packages as being "shared" allows us to use the Lumino version JupyterLab provides.