Build against JupyterLab 4 / Lumino 2 #417
Conversation
vthemelis
changed the title
|
Thank you for opening a PR! Unfortunately we'll be stuck waiting for ipywidgets to build against lab 4 before we can update jupyter-widgets/ipywidgets#3752 |
|
I think we can now resume this work |
vthemelis
force-pushed
the
lumino-2
branch
2 times, most recently
from
1978e19
to
7a8142d
Compare
vthemelis
force-pushed
the
lumino-2
branch
2 times, most recently
from
696efd7
to
c3fae79
Compare
|
@martinRenou, could you help me fix the Galata tests? I'm not super familiar with those. |
|
Sure I'll try to get your PR green. Thanks! |
vthemelis
force-pushed
the
lumino-2
branch
2 times, most recently
from
cc2cf9f
to
1b877a4
Compare
vthemelis
changed the title
|
@martinRenou, I think that this is now ready for review. You will also have to update the UI test artefacts (I don't think I can do that) but the tests run just fine. |
|
Thanks! I'll have a look very soonish, it's on my todo list |
|
Looking into it this afternoon! |
martinRenou
force-pushed
the
lumino-2
branch
from
bed4769
to
a7d2dec
Compare
|
Let's see, maybe the bot works: "update galata references" |
|
It has been triggered in https://github.com/bloomberg/ipydatagrid/actions/runs/6073498328 |
martinRenou
force-pushed
the
lumino-2
branch
from
814fb2f
to
cf1a6f2
Compare
|
Turns out the CI testing against ipywidgets 7 catches a real issue. ipydatagrid does not render when using ipywidgets 7 with this PR. I'm investigating. |
|
After more investigation, it's not an ipydatagrid issue but an ipywidgets issue. ipywidgets 7.x does not work with JupyterLab 4. We will want to report this to the ipywidgets repo. I don't know if it's possible to make a patch version of ipywidgets 7.x fixing this. I will update our visual regression tests to use JupyterLab 3 in ui-tests-ipw7 and JupyterLab 4 in ui-tests-ipw8. |
martinRenou
force-pushed
the
lumino-2
branch
from
67ecdb0
to
25bd985
Compare
ipydatagrid/_version.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright (c) Bloomberg. | |||
| # Distributed under the terms of the Modified BSD License. | |||
|
|
|||
| __version__ = "1.1.16" | |||
There was a problem hiding this comment.
We should bump this separately
There was a problem hiding this comment.
The package.json still has the new version I think
There was a problem hiding this comment.
Ooops I missed your comment, indeed it has. I'll make an 1.1.17 right away
* jlpm up '@lumino/*' * jlpm up '@jupyter-widgets/base' * jlpm up '@jupyterlab/*' * Same for a few loaders * Polyfill DragEvent * Remove JL<4 constraints * Upgrade Galata and Playwright * Fix UI tests * Bump to 1.2.0 * Update bump docs Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
lumino-2
branch
from
3b2d625
to
0fe7776
Compare
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
lumino-2
branch
from
0fe7776
to
307cc12
Compare
martinRenou
changed the title
Also fixes #431