Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoundedIntText: Pressing ENTER should trigger change event #2959

Closed
chaffra opened this issue Sep 1, 2020 · 4 comments · Fixed by #2975
Closed

BoundedIntText: Pressing ENTER should trigger change event #2959

chaffra opened this issue Sep 1, 2020 · 4 comments · Fixed by #2975

Comments

@chaffra
Copy link

chaffra commented Sep 1, 2020

Pressing ENTER after changing value of BoundedIntText does not trigger event change. Works for BoundedFloatText. To reproduce, run snippet below and try pressing ENTER after changing the value. Pressing Tab does what's expected.

num_rows = widgets.BoundedIntText(min=1, max=2**16, step=1, description='num_rows')
def on_value_change(change):
    print(change['new'])
num_rows.observe(on_value_change, names='value')
num_rows
@agoose77
Copy link
Contributor

agoose77 commented Sep 18, 2020

My team are currently developing a resource using ipywidgets, and all of the alpha testers have so far noticed this with IntText.

@gsteele13
Copy link

is there any progress on this? I also just noticed it, is is a bit annoying...?

@jasongrout
Copy link
Member

Looks like #2975 is a PR fixing it. I've added it to my review queue.

@jasongrout
Copy link
Member

@agoose77 - sorry I didn't see that PR earlier. Thanks for submitting it!

jasongrout added a commit to agoose77/ipywidgets that referenced this issue Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants