Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widgets do not compose well with cursor: default #3692

Open
maartenbreddels opened this issue Feb 3, 2023 · 4 comments
Open

widgets do not compose well with cursor: default #3692

maartenbreddels opened this issue Feb 3, 2023 · 4 comments

Comments

@maartenbreddels
Copy link
Member

Due to lumino:
https://github.com/jupyterlab/lumino/blob/dbb4f6aae04996abfbc5ee17d5fa8e693f3eb024/packages/widgets/style/widget.css#L19

All our widgets gets cursor: default. This means that when an Image widget is a child of an anchor tag (e.g. it's embedded in a container that turns the image into a link), we don't get a "hand" icon.

Not sure if lumino shouldn't do this, or if we should reset this.

@jasongrout
Copy link
Member

Yeah, I'm not sure that Lumino should do this either, it seems pretty heavy-handed if cursor is inherited. It looks like it was in since the beginning of Phosphor: https://github.com/jupyterlab/lumino/blame/42d1c2a646ac327da8b98f4a129a7d8947679ea6/styles/base.css#L25

@maartenbreddels
Copy link
Member Author

Should we do fixes in both ipywidgets and in lumino? For 7.x we still use phosphor which might be difficult to fix right?

@jasongrout
Copy link
Member

jasongrout commented Feb 3, 2023

For 7.x we still use phosphor which might be difficult to fix right?

Yes, it would be nigh impossible to fix Phosphor itself, but we could still do a CSS override in ipywidgets (though we should coordinate with JLab to make sure we are not messing up things in the system by overriding a fundamental CSS value)

maartenbreddels added a commit to maartenbreddels/ipywidgets that referenced this issue Feb 6, 2023
@maartenbreddels
Copy link
Member Author

Fixed in 7.x (#3696), needs a forward port to main/8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants