Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL resolver compilation. #2003

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix URL resolver compilation. #2003

merged 1 commit into from
Mar 20, 2018

Conversation

jasongrout
Copy link
Member

I had an error trying to compile:

> @jupyter-widgets/jupyterlab-manager@0.33.2 build:src [snip]/ipywidgets/packages/jupyterlab-manager
> tsc --project src

src/manager.ts(163,25): error TS2339: Property 'resolveUrl' does not exist on type 'IContext<IModel>'.

This fixes it.

@jasongrout jasongrout requested a review from vidartf March 20, 2018 04:42
@jasongrout jasongrout added this to the 7.2 milestone Mar 20, 2018
@vidartf
Copy link
Member

vidartf commented Mar 20, 2018

Yup, the change happened in jupyterlab/jupyterlab@970b579 . I guess I was working in an outdated dev env.

@vidartf vidartf merged commit b41d4dc into jupyter-widgets:master Mar 20, 2018
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vidartf vidartf Awaiting requested review from vidartf

Assignees
No one assigned
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jasongrout @vidartf