Ensure we fully resolve lab URLs #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Xref #1993 . |
|
See also jupyterlab/jupyterlab#4265. |
|
This looks good to me, though I think that the difference in meaning between JupyterLab and ipywidgets with regard to |
|
As in you think we should probably have called the widget manager function |
|
Just for consistency, yeah. If memory serves, we used to have a single function to do both, and then we broke it up into two functions in |
|
Okay. Well, we already released 7.2, so we can deprecate and change it for 8.0 if necessary. |
lock
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
resolveUrlon lab manager to give a download URL instead of a server path. The base implementation does not give a server path, so neither should the lab one. This will lead to a disconnect in the widget API name vs that used in jupyterlab, but I think that is acceptable.