Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying custom icons in ToggleButtons #2182

Closed
wants to merge 12 commits into from
Closed

Add support for specifying custom icons in ToggleButtons #2182

wants to merge 12 commits into from

Commits on Nov 21, 2018

  1. Add support for specifying custom icons in ToggleButtons

    @astrofrog @maartenbreddels
    astrofrog authored and maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    58107b1 View commit details
    Browse the repository at this point in the history

  2. turn icon into a Icon widget

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    63a04c0 View commit details
    Browse the repository at this point in the history

  3. update docstring and spec

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    bd42f14 View commit details
    Browse the repository at this point in the history

  4. do not require the label to be unqique

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    02e2392 View commit details
    Browse the repository at this point in the history

  5. renaming: view->this, item->label, items->labels

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    34f48af View commit details
    Browse the repository at this point in the history

  6. give icons a pointer icon as well

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    4020cd5 View commit details
    Browse the repository at this point in the history

  7. fix async issue using placeholder for icon

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    2bd8d8b View commit details
    Browse the repository at this point in the history

  8. move validation from Button to Icon

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    5d351dd View commit details
    Browse the repository at this point in the history

  9. fix async issue using placeholder for icon in ToggleButtons and Toggl… 

    …eButton as well
    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    33fa4e0 View commit details
    Browse the repository at this point in the history

  10. make sure the mouse pointer over the icon is really a pointer

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    e354ab5 View commit details
    Browse the repository at this point in the history

  11. cleanups

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    c11448d View commit details
    Browse the repository at this point in the history

  12. comments

    @maartenbreddels
    maartenbreddels committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    1c39b37 View commit details
    Browse the repository at this point in the history