Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alt text so images aren't duplicated in html #3013

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Nov 9, 2020

Fixes #2908 by using the workaround of adding a unique alt text to every image as proposed spatialaudio/nbsphinx#162

I think that the stable docs are probably based off the 7.x branch? so i will make a backport PR as well.

cc @jtpio

@jtpio
Copy link
Member

jtpio commented Nov 10, 2020

Nice, thanks @ianhi!

It would be great if we could enable the readthedocs preview, so we could check the rendered docs directly in the browser: #2921

@ianhi
Copy link
Contributor Author

ianhi commented Dec 12, 2020

@jasongrout if you have a chance would you consider merging this + the sibling PR #3014? I've recently found myself recommending people avoid that docs page in favor of the raw notebook https://gitter.im/jupyterlab/jupyterlab?at=5fd2a46d2a954a51a9c34191 and this is the fix for that.

@vidartf vidartf merged commit 90c1c14 into jupyter-widgets:master Jan 6, 2021
@jasongrout jasongrout added this to the 8.0 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Images in Low Level Widget Tutorial - All images are the same
4 participants