Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor outdated README #3099

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Refactor outdated README #3099

merged 2 commits into from
Feb 7, 2021

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Feb 7, 2021 •
edited
Loading

Closes #3076

This PR provides better user guidance for ipywidgets for classic notebook and nbclassic.

  • Surface where 7.6.3 release and docs exist
  • Improve nav to master resources
  • Add nav to 7.6.3
  • Update grammar for clarity
  • Rework compatibility table that is very outdated by making legacy everything before 7.6.3 and master

Backport to 7.x branch as well after merge.

@willingc willingc marked this pull request as ready for review February 7, 2021 18:45
@willingc
Copy link
Contributor Author

willingc commented Feb 7, 2021

Let's merge this as is since it provides more clarity than the existing outdated README. Folks can iterate on the compatibility table in a separate PR.

SylvainCorlay
SylvainCorlay approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@SylvainCorlay SylvainCorlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think I found a typo and left another comment.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@willingc willingc merged commit bd8ec45 into jupyter-widgets:master Feb 7, 2021
@willingc willingc deleted the update-rm branch February 7, 2021 19:43
willingc added a commit that referenced this pull request Feb 7, 2021
@willingc
Merge pull request #3101 from willingc/7.x
ef45312 
[Backport to 7.x] PR #3099
@jasongrout jasongrout added this to the 8.0 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

@jasongrout jasongrout Awaiting requested review from jasongrout

@ianhi ianhi Awaiting requested review from ianhi

@MSeal MSeal Awaiting requested review from MSeal

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Let's add reference to 7.x to README
3 participants
@willingc @SylvainCorlay @jasongrout