Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel is the source of truth: support multiple clients and fixes out of sync bug #3195

Merged
merged 15 commits into from
Dec 22, 2021
Merged

Kernel is the source of truth: support multiple clients and fixes out of sync bug #3195

merged 15 commits into from
Dec 22, 2021

Commits on Dec 7, 2021

  1. Fix frontends getting out of sync. 

    As described in jupyter-widgets#3111 it can happen that a frontend can get out of sync
due to not echoing back messages from the frontend.

Widgets can opt out of this behaviour if it is too costly and/or does
not make sense, e.g. the data from the file widget.

Fixes jupyter-widgets#3111
    @maartenbreddels
    maartenbreddels committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    7466482 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. avoid echo/jitter in frontend

    @maartenbreddels
    maartenbreddels committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    333dc8b View commit details
    Browse the repository at this point in the history

  2. put jupyter echo behaviour behind a flag

    @maartenbreddels
    maartenbreddels committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    8a37a8d View commit details
    Browse the repository at this point in the history

  3. minimize diff

    @maartenbreddels
    maartenbreddels committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    cf972d2 View commit details
    Browse the repository at this point in the history

  4. remove spacing

    @maartenbreddels
    maartenbreddels committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3808d7d View commit details
    Browse the repository at this point in the history

  5. prettier

    @maartenbreddels
    maartenbreddels committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c28572f View commit details
    Browse the repository at this point in the history

  6. lint

    @maartenbreddels
    maartenbreddels committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    13af754 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. fix: handle messages correctly when echoing disabled

    @mariobuikhuizen @maartenbreddels
    mariobuikhuizen authored and maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    ec186e4 View commit details
    Browse the repository at this point in the history

  2. minimize diff

    @maartenbreddels
    maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    4625793 View commit details
    Browse the repository at this point in the history

  3. minimize diff

    @maartenbreddels
    maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    b8f2a1b View commit details
    Browse the repository at this point in the history

  4. fix and test

    @maartenbreddels
    maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    f35a1ac View commit details
    Browse the repository at this point in the history

  5. fix test, do not use set (no determinstic order)

    @maartenbreddels
    maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    04d5714 View commit details
    Browse the repository at this point in the history

  6. fix: echos from other clients are not unexpected

    @mariobuikhuizen @maartenbreddels
    mariobuikhuizen authored and maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    da9cb86 View commit details
    Browse the repository at this point in the history

  7. comment and reformat

    @maartenbreddels
    maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    c9696e9 View commit details
    Browse the repository at this point in the history

  8. better variable name

    @maartenbreddels
    maartenbreddels committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    2d7909e View commit details
    Browse the repository at this point in the history