Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Jupyter Releaser #3298

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

davidbrochart
Copy link
Member

@davidbrochart davidbrochart commented Oct 14, 2021

Closes #3285

TODO

  • Format changelog so it's compatible with the releaser
  • Check whether we can keep the current changelog for 8.0
  • Do we want to version and release packages separately -> for now we'll version and commit separately (like for lumino)
  • bumpversion / tbump for bumping the Python packages? -> tbump can be used for each of the Python packages
  • Check how to handle ipywidgets depending on jupyterlab_widgets and widgetsnbextension:

    ipywidgets/setup.cfg

    Lines 42 to 43 in 441135a

    widgetsnbextension~=4.0a0
    jupyterlab_widgets~=2.0a0
    -> check how the releaser handles this
  • Check if the releaser can skip packages already published

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch davidbrochart/ipywidgets/jupyter_releaser

@davidbrochart
Copy link
Member Author

The bump-version.py script was copied over from Voilà, but I guess it has to be adapted to work here?

@davidbrochart
Copy link
Member Author

I ran "Draft Changelog" on my branch. From the logs, it looks like we would need to install JupyterLab in the draft-changelog action (because bump-version.py needs jlpm)?

@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

Thanks @davidbrochart for starting this!

it looks like we would need to install JupyterLab in the draft-changelog action (because bump-version.py needs jlpm)

Or we use yarn instead of jlpm? Since ./dev-install.sh also uses it to setup the development environment.

@davidbrochart
Copy link
Member Author

Actually I was missing some Jupyter Releaser hooks. But the problem is that the bump-version.py script needs lerna to be installed.

@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

Normally lerna should be installed when running yarn at the top level of the repo. So maybe we can keep that hook and run yarn instead of jlpm.

@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

@davidbrochart let's convert the PR to a draft while we iterate on it

@jtpio jtpio marked this pull request as draft October 15, 2021 12:48
@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

For reference the current release instructions are in https://github.com/jupyter-widgets/ipywidgets/blob/master/docs/source/dev_release.md. And it looks like the versioning is done manually by running the yarn run version command which calls lerna version:

"version": "yarn run clean && yarn run build && lerna version --no-push -m \"Bump version\" "

@jtpio
Copy link
Member

jtpio commented Oct 18, 2021

Edit: moving the TODO to the top comment.

@jtpio
Copy link
Member

jtpio commented Oct 19, 2021

OK this is kind of weird. The check seems to be canceled sometimes after 1 minute, sometimes after 5. This one for instance: https://github.com/jupyter-widgets/ipywidgets/pull/3298/checks?check_run_id=3940082517

image

@jtpio
Copy link
Member

jtpio commented Oct 19, 2021

sometimes after 1 minute, sometimes after 5

1 minute is probably because of ef786ca which removed the explicit install step. But it's strange that it is canceled instead of exiting on error.

@davidbrochart
Copy link
Member Author

Isn't it because when link_check fails, it cancels check_release?

@jtpio
Copy link
Member

jtpio commented Oct 19, 2021

Ah right, we are not using fail-fast: false for now: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

We can set it for now so it's easier to debug.

@jtpio jtpio force-pushed the jupyter_releaser branch 2 times, most recently from e2efa78 to 4b546f8 Compare November 17, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt the Jupyter Releaser for releases
2 participants