Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove process.cwd polyfill #3315

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Remove process.cwd polyfill #3315

merged 1 commit into from
Nov 23, 2021

Conversation

martinRenou
Copy link
Member

Fix #3312

I could not reproduce the HTML Manager issue there was when the polyfill was not around.

How I tested it:

jupyter nbconvert --to html --HTMLExporter.widget_renderer_url=./packages/html-manager/dist/embed-amd.js Notebook.ipynb

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch martinRenou/ipywidgets/remove_process_cwd

@vidartf vidartf merged commit d3356be into jupyter-widgets:master Nov 23, 2021
@jtpio jtpio mentioned this pull request Nov 30, 2021
Closed
@jasongrout jasongrout added this to the 8.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Do we still need the process.cwd polyfill?
3 participants
@martinRenou @jasongrout @vidartf