Introduce synchronous has_model function in the manager base class. #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies our code that has had to work around get_model either returning undefined or a rejected promise if a model was not registered. This paves the way for a future get_model in 8.0 that is truly asynchronous, never returning undefined.
martinRenou
approved these changes
Feb 11, 2022
Feel free to merge if it looks good to you! |
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this pull request
Feb 18, 2022
…manager base class From jupyter-widgets#3377. This simplifies our code that has had to work around get_model either returning undefined or a rejected promise if a model was not registered. This paves the way for a future get_model in 8.0 that is truly asynchronous, never returning undefined.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies our code that has had to work around get_model either returning undefined or a rejected promise if a model was not registered.
This paves the way for a future get_model in 8.0 that is truly asynchronous, never returning undefined.