Update public path to auto, and update example configs #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This also updates the examples to use the new webpack asset modules.
This follows the migration guide at https://evilmartians.com/chronicles/postcss-8-plugin-migration
It looks like browsers have basically supported css variables for about 5 years now, so the postcss processing isn't necessary anymore.
These were removed when changing to use the webpack asset loaders.
jasongrout
changed the title
jasongrout
changed the title
ibdafna
approved these changes
May 20, 2022
jasongrout
added a commit
to jasongrout/ipyleaflet
that referenced
this pull request
Jun 2, 2022
This means the files should be able to be hosted on any CDN. Also update the webpack image loaders to use the new asset/resource type. See also jupyter-widgets/ipywidgets#3464 and jupyter-widgets/widget-cookiecutter#103
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this pull request
Jul 6, 2022
Fixes jupyter-widgets#3474. This is another take on jupyter-widgets#3464, since that approach did not work to set the public path in AMD modules. Essentially, since AMD modules are executed asynchronously, the webpack 'auto' public path logic does not work. Instead, we use the requirejs-specific 'module' magic dependency, which allows us to get the path to the current AMD module, and use that to get the public path. We do this public path computation in a separate script to isolate it from any library code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by updating the public path to 'auto' so that we don't have to hardcode jsdelivr in the html manager. This broke examples, so I updated the examples' webpack config as well.