Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jupyterlite_contents #3540

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Fix jupyterlite_contents #3540

merged 4 commits into from
Aug 17, 2022

Conversation

jasongrout
Copy link
Member

It seems we are only getting one file in the jlite contents these days, which started happening right around the time we switched to jupyterlite_sphinx 0.7.0.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jasongrout/ipywidgets/jlitecontents

martinRenou
martinRenou approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks

@jasongrout jasongrout closed this Aug 16, 2022
@jasongrout jasongrout reopened this Aug 16, 2022
@jasongrout
Copy link
Member Author

Docs is failing to build:

yarn install v1.21.1
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error An unexpected error occurred: "https://registry.npmjs.org/corser/-/corser-2.0.1.tgz: Request failed \"503 Service Unavailable\"".

So I'll try again in a bit.

jasongrout-db
jasongrout-db reviewed Aug 17, 2022
View reviewed changes
docs/source/conf.py Outdated Show resolved Hide resolved
@jasongrout jasongrout added this to the 8.0 milestone Aug 17, 2022
@jasongrout
Fix jupyterlite contents
bf361d4 
jupyterlite-sphinx 0.7.0 inadvertently disabled having jupyterlite_contents being a single string, so we make it an array.
@jasongrout jasongrout changed the title Change jupyterlite_contents to a glob, as it is in jupyterlite_sphinx 0.7.0 Fix jupyterlite_contents Aug 17, 2022
@jasongrout
Copy link
Member Author

Looks like the actual error was that jupyterlite_contents inadvertently can't be a string anymore, so I changed it to an array. I put in a fix for jupyterlite_sphinx in jupyterlite/jupyterlite-sphinx#73

@jasongrout
Copy link
Member Author

I put in a fix for jupyterlite_sphinx in jupyterlite/jupyterlite-sphinx#73

And @martinRenou is amazingly fast at releasing, and the fix is now in jupyterlite-sphinx 0.7.2. Thanks Martin!

vidartf
vidartf reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Can we use a local path for the nbextension? If not, we will need to update that line for every release, right?

docs/source/jupyter_lite_config.json Outdated Show resolved Hide resolved
@vidartf vidartf merged commit 62ad153 into jupyter-widgets:master Aug 17, 2022
@jtpio jtpio mentioned this pull request Aug 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongrout-db jasongrout-db jasongrout-db left review comments

@vidartf vidartf vidartf approved these changes

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jasongrout @vidartf @martinRenou @jasongrout-db