Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make .widget and .widget_types deprecated #3567

Merged
merged 9 commits into from
Sep 13, 2022
Merged

fix: make .widget and .widget_types deprecated #3567

merged 9 commits into from
Sep 13, 2022

Commits on Aug 24, 2022

  1. fix: make .widget and .widget_types deprecated 

    In jupyter-widgets#3122 we renamed .widget and .widget_types to ._active_widgets
and ._widget_types. That breaks code, and we did not have a deprecation
period.
This PR makes the dict and registry non-members of the Widget class
and puts in a backwards compatible way the deprecated these members.
    @maartenbreddels
    maartenbreddels committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ca91f89 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Update python/ipywidgets/ipywidgets/widgets/widget.py 

    Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
    @maartenbreddels @jasongrout
    maartenbreddels and jasongrout authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    e7b941d View commit details
    Browse the repository at this point in the history

  2. Update python/ipywidgets/ipywidgets/widgets/widget.py 

    Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
    @maartenbreddels @jasongrout
    maartenbreddels and jasongrout authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    5134ea0 View commit details
    Browse the repository at this point in the history

  3. rename to _instances

    @maartenbreddels
    maartenbreddels committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    75c8f57 View commit details
    Browse the repository at this point in the history

  4. rename to _registry

    @maartenbreddels
    maartenbreddels committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    e63740e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. do not advertise private apis

    @maartenbreddels
    maartenbreddels committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    924f383 View commit details
    Browse the repository at this point in the history

  2. Add migration docs about deprecating .widgets and .widget_types

    @jasongrout
    jasongrout committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    25acec5 View commit details
    Browse the repository at this point in the history

  3. Import internal references as relative imports

    @jasongrout
    jasongrout committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    db41eab View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Merge pull request #2 from jasongrout/fix_widgets_and_widget_types 

    Move internal references to relative imports, add migration note
    @maartenbreddels
    maartenbreddels authored Sep 9, 2022
    Configuration menu
    Copy the full SHA
    ae33123 View commit details
    Browse the repository at this point in the history