Update to jupyterlab 4 and lumino 2 #3707

echarles · 2023-02-23T12:46:20Z

github-actions · 2023-02-23T12:46:35Z

👈 Launch a binder notebook on branch datalayer-externals/ipywidgets/jupyterlab4

martinRenou

Thanks for starting this!

martinRenou · 2023-02-23T13:26:27Z

packages/base/package.json

+ "@lumino/coreutils": "^2.0.0-beta.0",
+ "@lumino/messaging": "^2.0.0-beta.0",
+ "@lumino/widgets": "^2.0.0-beta.0",


I'd suggest being soft on the Lumino dependencies:

Suggested change

"@lumino/coreutils": "^2.0.0-beta.0",

"@lumino/messaging": "^2.0.0-beta.0",

"@lumino/widgets": "^2.0.0-beta.0",

"@lumino/coreutils": "^1.11.1 || ^2.0.0-beta.0",

"@lumino/messaging": "^1.10.1 || ^2.0.0-beta.0",

"@lumino/widgets": "^1.30.0 || ^2.0.0-beta.0",

That way people won't get warnings in the JS console with JupyterLab 3.

yes, that would be the goal. I'd like first to get the CI green with more strict constraints on lumino.

echarles · 2023-02-23T15:33:51Z

Among the failed CI jobs, there is the Javascript one. Is CI main branch supposed to be 100% green?

@jupyter-widgets/html-manager: webpack 5.75.0 compiled with 3 warnings in 20474 ms
@jupyter-widgets/html-manager: > @jupyter-widgets/html-manager@1.0.5 build:embed-amd
@jupyter-widgets/html-manager: > node scripts/concat-amd-build.js && rimraf dist/amd


 >  Lerna (powered by Nx)   Running target build for 7 projects failed

   Tasks not run because their dependencies failed or --nx-bail=true:
   
   - @jupyter-widgets/notebook-manager:build
   
   Failed tasks:
   
   - @jupyter-widgets/jupyterlab-manager:build

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

echarles · 2023-02-24T10:12:10Z

@martinRenou I have pushed fixes and this PR still requests approval. Is this possible to simply have the CI run on each commit without asking approval?

echarles · 2023-02-25T09:46:59Z

I have pushed more updates for the CI and the CI running in my fork is now better. There is still one failure related to galata usage, see the details here. @fcollonval may have an idea how to investigate this, probably related to galata API changes between 3.x and 4.x ?

cd ui-tests
  yarn test
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:3).11.2/x6[4](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:4)
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.2/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.2/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.2/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.2/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.2/x64/lib
  
yarn run v1.22.19
$ playwright test

Running 1 test using 1 worker
×F

  1) tests/widgets.test.ts:19:7 › Widget Visual Regression › Run notebook widgets.ipynb and capture cell outputs 

    Error: Failed to activate galata extension

        at Proxy.hookHelpersUp (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:669:13)
        at Proxy.goto (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:474:[5](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:5))
        at Object.initTestPage (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:284:7)
        at Object.page [as fn] (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/fixtures.ts:371:7)

    attachment #1: video (video/webm) ──────────────────────────────────────────────────────────────
    test-results/tests-widgets-Widget-Visual-Regression-Run-notebook-widgets-ipynb-and-capture-cell-outputs/video.webm
    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────

    Error: Failed to activate galata extension

        at Proxy.hookHelpersUp (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:[6](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:6)69:13)
        at Proxy.goto (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:4[7](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:7)4:5)
        at Object.initTestPage (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:2[8](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:8)4:7)
        at Object.page [as fn] (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/fixtures.ts:371:7)

    attachment #1: video (video/webm) ──────────────────────────────────────────────────────────────
    test-results/tests-widgets-Widget-Visual-Regression-Run-notebook-widgets-ipynb-and-capture-cell-outputs-retry1/video.webm
    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    tests/widgets.test.ts:1[9](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:9):7 › Widget Visual Regression › Run notebook widgets.ipynb and capture cell outputs 
Error:   1) tests/widgets.test.ts:19:7 › Widget Visual Regression › Run notebook widgets.ipynb and capture cell outputs 
    Error: Failed to activate galata extension

        at Proxy.hookHelpersUp (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:669:[13](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:14))
        at Proxy.goto (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:474:5)
        at Object.initTestPage (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:284:7)
        at Object.page [as fn] (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/fixtures.ts:371:7)
Error:   1) tests/widgets.test.ts:[19](https://github.com/datalayer-externals/ipywidgets/actions/runs/4269369026/jobs/7432505017#step:11:20):7 › Widget Visual Regression › Run notebook widgets.ipynb and capture cell outputs 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Failed to activate galata extension

        at Proxy.hookHelpersUp (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:669:13)
        at Proxy.goto (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/jupyterlabpage.ts:474:5)
        at Object.initTestPage (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:284:7)
        at Object.page [as fn] (/home/runner/work/ipywidgets/ipywidgets/ui-tests/node_modules/@jupyterlab/galata/src/fixtures.ts:371:7)
Notice:   1 failed
    tests/widgets.test.ts:19:7 › Widget Visual Regression › Run notebook widgets.ipynb and capture cell outputs 
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

fcollonval · 2023-02-27T07:35:44Z

@echarles the setup of galata in JLab 4 is changing (the helpers are loaded as a regular JupyterLab extension):

https://github.com/jupyterlab/jupyterlab/tree/master/galata#launch-jupyterlab

echarles · 2023-02-27T07:47:35Z

Thx for the link. I have tried to implement those changes in a simple extension without luck. Do you have a link to an extension depending on jupyterlab4 that runs galata tests?

jtpio · 2023-03-30T16:19:24Z

Thx for the link. I have tried to implement those changes in a simple extension without luck. Do you have a link to an extension depending on jupyterlab4 that runs galata tests?

Maybe this PR that updated the cookiecutter? jupyterlab/extension-cookiecutter-ts#287

echarles · 2023-04-05T04:39:35Z

Suprised to see #3752.

Can you sync?

tarrade · 2023-05-16T11:37:31Z

Jupyterlab 4.0.0 was release yesterday https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0 and it seems a new version with this PR is needed to work with jupyterlab-4.0.0, correct ?

Using conda, I am getting:
"package jupyterlab_widgets-3.0.7-pyhd8ed1ab_0 has constraint jupyterlab >=3,<4 conflicting with jupyterlab-4.0.0-pyhd8ed1ab_1"

martinRenou · 2023-05-16T12:24:36Z

Using conda, I am getting:
"package jupyterlab_widgets-3.0.7-pyhd8ed1ab_0 has constraint jupyterlab >=3,<4 conflicting with jupyterlab-4.0.0-pyhd8ed1ab_1"

@tarrade this has to do with the conda package itself which has a run constraint. It was resolved in conda-forge/jupyterlab_widgets-feedstock#26 and you will be able to install latest ipywidgets with JupyterLab 4 in ~1 hour.

tarrade · 2023-05-16T15:25:55Z

Using conda, I am getting:
"package jupyterlab_widgets-3.0.7-pyhd8ed1ab_0 has constraint jupyterlab >=3,<4 conflicting with jupyterlab-4.0.0-pyhd8ed1ab_1"

@tarrade this has to do with the conda package itself which has a run constraint. It was resolved in conda-forge/jupyterlab_widgets-feedstock#26 and you will be able to install latest ipywidgets with JupyterLab 4 in ~1 hour.

perfect, pb solved, thanks a lot

martinRenou · 2023-07-31T13:17:42Z

Closing as replaced by #3752, I made sure to keep you as a committer as it was built upon your work. Thank you!

deps: update to jupyterlab 4.alpha and lumino 2.beta

727e23c

echarles marked this pull request as draft February 23, 2023 12:46

echarles mentioned this pull request Feb 23, 2023

Available for documentation/information about ipywidgets and Jupyterlab 4 #3700

Open

martinRenou reviewed Feb 23, 2023

View reviewed changes

echarles added 2 commits February 24, 2023 11:05

fix build

b743701

yarn lock

0516dc1

echarles added 6 commits February 24, 2023 11:23

ci: test with jupyterlab 4.0.0a34

14e85dc

ci: discard python 3.7 as jupyterlab4 does not support it

a440610

ci: test with jupyterlab 4.0.0a34

97f357b

lint

d36a8da

ci: try to fix the visual regression flow

f1163aa

ci: try to fix Visual Regression workflow

d5225fd

yarn.lock

b1cc736

galata: server config

0c18fb2

martinRenou marked this pull request as ready for review March 31, 2023 07:06

martinRenou mentioned this pull request Apr 4, 2023

Add support for building against JupyterLab 4 and Lumino 2 #3752

Merged

martinRenou closed this Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to jupyterlab 4 and lumino 2 #3707

Update to jupyterlab 4 and lumino 2 #3707

echarles commented Feb 23, 2023

github-actions bot commented Feb 23, 2023

martinRenou left a comment

martinRenou Feb 23, 2023

echarles Feb 23, 2023

echarles commented Feb 23, 2023

echarles commented Feb 24, 2023

echarles commented Feb 25, 2023

fcollonval commented Feb 27, 2023

echarles commented Feb 27, 2023

jtpio commented Mar 30, 2023

echarles commented Apr 5, 2023

tarrade commented May 16, 2023

martinRenou commented May 16, 2023

tarrade commented May 16, 2023

martinRenou commented Jul 31, 2023 •

edited

Loading

Update to jupyterlab 4 and lumino 2 #3707

Update to jupyterlab 4 and lumino 2 #3707

Conversation

echarles commented Feb 23, 2023

github-actions bot commented Feb 23, 2023

martinRenou left a comment

Choose a reason for hiding this comment

martinRenou Feb 23, 2023

Choose a reason for hiding this comment

echarles Feb 23, 2023

Choose a reason for hiding this comment

echarles commented Feb 23, 2023

echarles commented Feb 24, 2023

echarles commented Feb 25, 2023

fcollonval commented Feb 27, 2023

echarles commented Feb 27, 2023

jtpio commented Mar 30, 2023

echarles commented Apr 5, 2023

tarrade commented May 16, 2023

martinRenou commented May 16, 2023

tarrade commented May 16, 2023

martinRenou commented Jul 31, 2023 • edited Loading

martinRenou commented Jul 31, 2023 •

edited

Loading