Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLite 0.1.0 #3820

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 3, 2023

Changes:

  • Update to jupyterlite >=0.1.0,<0.2.0
  • Install jupyterlite from conda forge in the docs environment

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Binder 👈 Launch a binder notebook on branch jtpio/ipywidgets/update-latest-jupyterlite

@jtpio jtpio marked this pull request as ready for review August 3, 2023 08:29
@jtpio jtpio requested a review from martinRenou August 3, 2023 08:52
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now that xeus-python has stabilized a bit, splitting the huge kernel file into multiple small files easy to cache, performing better at startup, I would be in favor of replacing pyodide-kernel by jupyterlite-xeus-python in the docs. What do you think?

It can also now use a dev version of ipywidgets since you can now pip install stuffs in the emscripten environment. Allowing us to test ipywidgets directly in PRs without spawning binder.

@martinRenou martinRenou merged commit e1718c2 into jupyter-widgets:main Aug 3, 2023
20 checks passed
@jtpio jtpio deleted the update-latest-jupyterlite branch August 3, 2023 11:44
@jtpio
Copy link
Member Author

jtpio commented Aug 3, 2023

Good point, we could indeed give jupyterlite-xeus-python another try, especially since now it's also a bit faster to start.

Out of curiosity I quickly compared the Pyodide and Xeus Python kernels locally and here are some numbers:

jupyterlite-pyodide-kernel==0.1.0

image

jupyterlite-xeus-python==0.9.2

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants