Ipywidgets 8 support #378
Ipywidgets 8 support #378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 70.86% 70.04% -0.82%
==========================================
Files 23 23
Lines 834 888 +54
==========================================
+ Hits 591 622 +31
- Misses 243 266 +23
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jupyter_client has deprecated support for non-finite floats, and aggressively prints to stderr if you try to serialize them. Notes: We do not need a deserializer, as CFloats will handle the conversion in its validator. We were already relying on this fact, so no change. Similarly, the JS convertFloat[...] functions continue to serialize/deserialize there. This also extends Vector/Matrix/Euler to support IEEE floats.
| @@ -96,39 +97,36 @@ _.extend(RendererPool.prototype, { | |||
| depth: true, | |||
| stencil: true, | |||
| premultipliedAlpha: true, | |||
| preserveDrawingBuffer: false, | |||
| preserveDrawingBuffer: true, | |||
There was a problem hiding this comment.
This fixes a bug for webgl2, which could be seen in the "renderer_limit" notebook
| @@ -324,7 +324,7 @@ function nestedDiff(newObj, oldObj) { | |||
| } else { | |||
| diff = dictDiff(newObj, oldObj); | |||
| } | |||
| var all = _.flatten([diff.added, diff.removed, diff.kept]); | |||
| var all = [...diff.added, ...diff.removed, ...diff.kept]; | |||
There was a problem hiding this comment.
This fixes a bug for listening to certain arrays in dicts structures.
|
@akaszynski Do you want to do a review / test this? |
|
Hello vidartf, I’m a newbie programmer working with Jupyter Notebook and pythreejs. All 3 of my project files at https://github.com/LtAirman/ChargeFieldTopics stopped working this morning. They no longer display the pythreejs rendered scene. Over the last few months the cell setting up the rendered scene displayed a UserWarning, due to non JSON compliant infinite values. I believe you identified the problem, involving the pythreejs orbital camera, in issues 366 and 378 which I’ve been following. It was my impression this non-finite number problem would be corrected with the upcoming ipywidget 8 release, seeing no rendered output at all is an awful surprise. I assume it's the same issue. What do I do now? I’d appreciate any guidance or information you might provide in this matter. |
|
Update, happy to report my projects' pythreejs rendered outputs are now working properly. |
|
Along with the UserWarning. |
Ipywidgets 8 is above to be released, and some changes are needed to support it:
.extend()method from the base classes anymore. We should switch to usingclass ... extendspattern (switched to es2018 throughout)._ipython_display_for the preview anymore. We should switch to_repr_mimebundle_.