fix: initialize Term::Button::Type type to resolve uninitialized variable exception in event.cpp
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialized variable exception
This was referenced Dec 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In Windows Terminal on Windows 11, using CTRL+ Mouse Scroll🖱️ was causing the following exception:
Exception has occurred: The variable 'type' is being used without being initialized.This occurred because the
Term::Button::Type typevariable was accessed without being properly initialized during the event handling.Solution:
The
typevariable has been explicitly initialized toButton::Type::None, ensuring that it has a valid default value before being accessed. This prevents the uninitialized variable exception.Impact:
This fix resolves the exception triggered by CTRL+ Mouse Scroll🖱️ in Windows Terminal, allowing the event to be processed without errors.
While this fix resolves the crash, zooming with CTRL+ Mouse Scroll🖱️ is still not functional. (Different of CTRL+ or CTRL-)
This PR does not address the zoom functionality.