unify-wasm-kernels #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DerThorsten
commented
Nov 27, 2023
•
DerThorsten
commented
- also build test kernel for the browser and not only for node
- install test kernel properly st. we can consume it jupyterlite.
- added xeus-lite logo which is just the xeus logo itself
- added kernelspec kernel.json for testkernel
- deleted typescript code, this will not needed any more
Closed
There was a problem hiding this comment.
If you delete the ts files, you can also remove the line
set(XEUS_LITE_TS_INSTALL_DIR "${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME}" CACHE STRING "install path for typescript files")
from this CMakeLists.txt.
(I did not find how to comment on a line that is not in the diff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.