Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use console logger #61

Merged
merged 4 commits into from
Dec 7, 2023
Merged

use console logger #61

merged 4 commits into from
Dec 7, 2023

Conversation

romainfrancois
Copy link
Contributor

closes #48

This uses a xeus::make_console_logger(xeus::xlogger::full) for now, perhaps later we should use a xeus::make_file_logger as well, perhaps based on an R option, e.g. in IRkernel :

#' Kernel logging functions
#'
#' A set of exported logging utilities that have the capability to be used in upstream projects.
#' Log level and log file can be set via R package options e.g. \code{options(jupyter.log_level = 2L)}
#' or from the environment variables JUPYTER_LOG_LEVEL and JUPYTER_LOGFILE.

@romainfrancois
Copy link
Contributor Author

I'm not sure how to send a log message to the kernel's p_logger directly, so that e.g. the R code might contribute to the logs.

@romainfrancois
Copy link
Contributor Author

I'll follow up in a different issue/pr.

@romainfrancois romainfrancois merged commit fa9d293 into main Dec 7, 2023
2 checks passed
@romainfrancois romainfrancois deleted the logging branch December 7, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging
1 participant