Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes after #71 #73

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

anutosh491
Copy link
Collaborator

No description provided.

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Jun 29, 2024

Hey @JohanMabille

I think #71 drops notify_kernel_dead from the xclient_zmq.hpp/cpp (noted here). Is there any reason for doing so ?

We have the kernel_status_listener and the register_kernel_status_listener though. Will add the notify function back on if required.

@JohanMabille
Copy link
Member

Thnaks for removing the leftovers ;)
notify_kernel_dead (like other notify_xxx) is not a public API, and was actually necer called. Only that of xclient_zmq_impl was, so ne need to have it in xclient_zmq.

@JohanMabille JohanMabille merged commit ac45ec5 into jupyter-xeus:main Jun 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants