Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notify socket listener calls #74

Merged
merged 1 commit into from
Jun 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions include/xeus-zmq/xclient_zmq.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ namespace xeus
void wait_for_message();

private:

void notify_shell_listener(xmessage msg);
void notify_control_listener(xmessage msg);
void notify_iopub_listener(xpub_message msg);

std::unique_ptr<xclient_zmq_impl> p_client_impl;
};
Expand Down
15 changes: 0 additions & 15 deletions src/client/xclient_zmq.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -91,21 +91,6 @@ namespace xeus
{
p_client_impl->wait_for_message();
}

void xclient_zmq::notify_shell_listener(xmessage msg)
{
p_client_impl->notify_shell_listener(std::move(msg));
}

void xclient_zmq::notify_control_listener(xmessage msg)
{
p_client_impl->notify_control_listener(std::move(msg));
}

void xclient_zmq::notify_iopub_listener(xpub_message msg)
{
p_client_impl->notify_iopub_listener(std::move(msg));
}

std::unique_ptr<xclient_zmq> make_xclient_zmq(xcontext& context,
const xconfiguration& config,
Expand Down
10 changes: 5 additions & 5 deletions src/client/xclient_zmq_impl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@ namespace xeus
void connect();
void stop_channels();

void notify_shell_listener(xmessage msg);
void notify_control_listener(xmessage msg);
void notify_iopub_listener(xpub_message msg);
void notify_kernel_dead(bool status);

void wait_for_message();
void start();

Expand All @@ -86,6 +81,11 @@ namespace xeus
void start_heartbeat_thread();
void poll(long timeout);

void notify_shell_listener(xmessage msg);
void notify_control_listener(xmessage msg);
void notify_iopub_listener(xpub_message msg);
void notify_kernel_dead(bool status);

using authentication_ptr = std::unique_ptr<xauthentication>;
authentication_ptr p_auth;

Expand Down