Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify wasm options #372

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

DerThorsten
Copy link
Member

@DerThorsten DerThorsten commented Nov 20, 2023

See jupyter-xeus/xeus-lite#7 for details, but in a nutshell, we want all xeus-wasm kernels to be as similar / unified as we can. Therefore we:

  • drop the async option from the wasm options. If a kernel really wants to be async, the flag can be set in the kernel directly.
  • force all kernels to use dynamic linking (even though atm this is only used by python, most kernels should use that, in particular lua and any upcoming R kernel)

In this PR we:

  • drop the async option function
  • added the needed flags for dynamic linking (MAIN_MODULE)
  • removed the filesystem option and just force a filesystem for all kernels
  • add POSITION_INDEPENDENT_CODE flag for all kernels, ie -fPIC, since this is mandatory for all used libraries when using dynamic linking.
  • remove superfluous flag XEUS_EMSCRIPTEN_WASM_BUILD to indicate emscripten build, we can just use EMSCRIPTEN which already does the job.

@DerThorsten DerThorsten marked this pull request as ready for review November 28, 2023 08:29
@JohanMabille JohanMabille merged commit 3fc567a into jupyter-xeus:main Nov 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants