Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jupyter-xeus/xeus-lite#7 for details, but in a nutshell, we want all xeus-wasm kernels to be as similar / unified as we can. Therefore we:
In this PR we:
MAIN_MODULE
)POSITION_INDEPENDENT_CODE
flag for all kernels, ie-fPIC
, since this is mandatory for all used libraries when using dynamic linking.XEUS_EMSCRIPTEN_WASM_BUILD
to indicate emscripten build, we can just useEMSCRIPTEN
which already does the job.