Skip to content

Commit 8890fc5

Browse files
authored
Fix ijavascript example (#2143)
* Fix ijavascript example * Better naming
1 parent 348cc09 commit 8890fc5

File tree

2 files changed

+26
-11
lines changed

2 files changed

+26
-11
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
FROM quay.io/jupyter/base-notebook
2+
3+
USER root
4+
5+
RUN apt-get update --yes && \
6+
apt-get install --yes --no-install-recommends \
7+
make \
8+
g++ && \
9+
apt-get clean && rm -rf /var/lib/apt/lists/*
10+
11+
USER ${NB_UID}
12+
13+
# NodeJS <= 20 is required
14+
# https://github.com/n-riesco/ijavascript/issues/184
15+
RUN mamba install --yes nodejs=20.* && \
16+
mamba clean --all -f -y && \
17+
fix-permissions "${CONDA_DIR}" && \
18+
fix-permissions "/home/${NB_USER}"
19+
20+
# hadolint ignore=DL3016
21+
RUN npm install -g ijavascript
22+
# hadolint ignore=DL3059
23+
RUN ijsinstall

docs/using/recipes.md

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -482,18 +482,10 @@ docker run -it --rm \
482482

483483
## Add ijavascript kernel to container
484484

485-
```{warning}
486-
This recipe is not tested and might be broken.
487-
```
488-
489-
The example below is a Dockerfile to install the [ijavascript kernel](https://github.com/n-riesco/ijavascript).
485+
The example below is a Dockerfile to install the [IJavascript kernel](https://github.com/n-riesco/ijavascript).
490486

491-
```dockerfile
492-
FROM quay.io/jupyter/scipy-notebook
493-
494-
# install ijavascript
495-
RUN npm install -g ijavascript
496-
RUN ijsinstall
487+
```{literalinclude} recipe_code/ijavascript.dockerfile
488+
:language: docker
497489
```
498490

499491
## Add Microsoft SQL Server ODBC driver

0 commit comments

Comments
 (0)