Skip to content

Commit

Permalink
Compare env variable with string 'true' value
Browse files Browse the repository at this point in the history
  • Loading branch information
mathbunnyru committed Oct 31, 2023
1 parent c27ab18 commit af37e9c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docker-merge-tags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ jobs:
shell: bash

- name: Login to Registry 🔐
if: env.PUSH_TO_REGISTRY
if: env.PUSH_TO_REGISTRY == 'true'
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
registry: quay.io
username: ${{ secrets.REGISTRY_USERNAME }}
password: ${{ secrets.REGISTRY_TOKEN }}

- name: Merge tags for the images 🔀
if: env.PUSH_TO_REGISTRY
if: env.PUSH_TO_REGISTRY == 'true'
run: python3 -m tagging.merge_tags --short-image-name ${{ inputs.image }} --tags-dir /tmp/jupyter/tags/
shell: bash
4 changes: 2 additions & 2 deletions .github/workflows/docker-tag-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
platform: ${{ inputs.platform }}

- name: Login to Registry 🔐
if: env.PUSH_TO_REGISTRY
if: env.PUSH_TO_REGISTRY == 'true'
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
registry: quay.io
Expand All @@ -54,6 +54,6 @@ jobs:
run: python3 -m tagging.apply_tags --short-image-name ${{ inputs.image }} --tags-dir /tmp/jupyter/tags/ --platform ${{ inputs.platform }} --registry ${{ env.REGISTRY }} --owner ${{ env.OWNER }}

- name: Push Images to Registry 📤
if: env.PUSH_TO_REGISTRY
if: env.PUSH_TO_REGISTRY == 'true'
run: docker push --all-tags ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ inputs.image }}
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/docker-wiki-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
shell: bash

- name: Push Wiki to GitHub 📤
if: env.PUSH_TO_REGISTRY
if: env.PUSH_TO_REGISTRY == 'true'
uses: stefanzweifel/git-auto-commit-action@8756aa072ef5b4a080af5dc8fef36c5d586e521d # v5.0.0
with:
commit_message: "Automated wiki publish for ${{ github.sha }}"
Expand Down

0 comments on commit af37e9c

Please sign in to comment.