Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to run on all applicable images #1621

Closed
mathbunnyru opened this issue Feb 12, 2022 · 2 comments · Fixed by #1634
Closed

Refactor tests to run on all applicable images #1621

mathbunnyru opened this issue Feb 12, 2022 · 2 comments · Fixed by #1634
Labels
type:Enhancement A proposed enhancement to the docker images type:Testing

Comments

@mathbunnyru
Copy link
Member

Right now, it works like this:

  • there is a test folder, which is run for every image
  • image specific tests folder

What I propose:
If a test is run for some image, then it should run for all dependent images.
This way we will make sure, that some feature works in all the images it should work.
And we will be able to put our common tests to /tests/base-notebook and every image will run these tests automatically.

@mathbunnyru mathbunnyru added type:Enhancement A proposed enhancement to the docker images type:Testing labels Feb 12, 2022
@trallard
Copy link
Member

This sounds like a sensible proposal.

And we will be able to put our common tests to /tests/base-notebook and every image will run these tests automatically.

I would suggest instead something like tests/images-common or something similar. It will make it clearer that those tests are for all the images and not solely for the base-notebook thus preventing confusion in the future?

@mathbunnyru
Copy link
Member Author

I already implemented this in my local repo, will draft a PR in the evening - please, take a look, I tried to improve the documentation, so it's more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images type:Testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants