You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there is a test folder, which is run for every image
image specific tests folder
What I propose:
If a test is run for some image, then it should run for all dependent images.
This way we will make sure, that some feature works in all the images it should work.
And we will be able to put our common tests to /tests/base-notebook and every image will run these tests automatically.
The text was updated successfully, but these errors were encountered:
And we will be able to put our common tests to /tests/base-notebook and every image will run these tests automatically.
I would suggest instead something like tests/images-common or something similar. It will make it clearer that those tests are for all the images and not solely for the base-notebook thus preventing confusion in the future?
I already implemented this in my local repo, will draft a PR in the evening - please, take a look, I tried to improve the documentation, so it's more clear.
Right now, it works like this:
What I propose:
If a test is run for some image, then it should run for all dependent images.
This way we will make sure, that some feature works in all the images it should work.
And we will be able to put our common tests to
/tests/base-notebook
and every image will run these tests automatically.The text was updated successfully, but these errors were encountered: