Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on all children images #1634

Merged
merged 13 commits into from
Feb 21, 2022
Merged

Run tests on all children images #1634

merged 13 commits into from
Feb 21, 2022

Conversation

mathbunnyru
Copy link
Member

Fix: #1621

@mathbunnyru
Copy link
Member Author

The docs are expected to fail, because some links do not exist yet.

@mathbunnyru
Copy link
Member Author

@trallard please, take a look.

@trallard
Copy link
Member

Thanks for the ping @mathbunnyru I will try and have a look over the weekend otherwise I can do it on Monday

trallard
trallard reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a sensible approach @mathbunnyru and has actually given me some guidance on how to go about enforcing the hierarchy in the PR I am working on.

Apart from that, I added some comments and suggestions 😉

tests/README.md Outdated Show resolved Hide resolved
docs/contributing/tests.md Outdated Show resolved Hide resolved
docs/contributing/tests.md Outdated Show resolved Hide resolved
docs/contributing/tests.md Outdated Show resolved Hide resolved
docs/contributing/tests.md Outdated Show resolved Hide resolved
tests/images_hierarchy.py Outdated Show resolved Hide resolved
docs/contributing/tests.md Outdated Show resolved Hide resolved
mathbunnyru and others added 2 commits February 21, 2022 13:25
@mathbunnyru @trallard
Apply suggestions from code review
87b6f94 
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
75ad86f 
for more information, see https://pre-commit.ci
@mathbunnyru
Copy link
Member Author

I think this is good to go.
Thank you for the review @trallard 👍

@mathbunnyru mathbunnyru merged commit 5cb1a91 into jupyter:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard left review comments

@consideRatio consideRatio Awaiting requested review from consideRatio

@romainx romainx Awaiting requested review from romainx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tests to run on all applicable images
2 participants
@mathbunnyru @trallard