-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Miniconda to Miniforge #1189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
reviewed
Nov 13, 2020
Another great advantage is an ability to use pypy - maybe someone wants it, because it might give good speed improvement. |
LGTM |
romainx
added
the
status:Ready to Merge
PR reviewed, up-to-date, and ready to merge
label
Nov 24, 2020
Fix the CondaPackageHelper to handle cases when conda spec is expressed with two `=` signs instead of a single one.
parente
approved these changes
Nov 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks very good to me, @romainx. Thanks for staying on top of conda developments. Merging now. We can deal with issues as they arise.
This was referenced Nov 29, 2020
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status:Ready to Merge
PR reviewed, up-to-date, and ready to merge
type:Enhancement
A proposed enhancement to the docker images
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm trying to perform a structuring change by switching from Miniconda installer to Miniforge.
Here are the main reasons
conda-forge
channel by defaultARGS
), could be a good asset to build multi-arch images.Miniforge-pypy3
(thanks @mathbunnyru)Some minor pros
Implementation
ARGs
to ease overriding and for better clarity (I hope)MINICONDA_VERSION
because I'm not sure it makes sense to replace it by the Miniforge equivalentstrict
channel priority of theconda
installer becauseARG
instead of downloading it for security reasons (@mathbunnyru suggestion)defaults
channelsNotes on multi-arch images
Here is a table displaying the various CPU architecture available
arm64
linux-aarch64
amd64
linux-x86_64
Linux-x86_64.sh
ppc64le
linux-ppc64le
Linux-ppc64le.sh
List of
ubuntu:focal
architectures