Make docs build process less obscure #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Jun 20, 2021
| @@ -8,6 +8,7 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
| - main | |||
There was a problem hiding this comment.
If we ever rename to main, nothing should actually break.
There was a problem hiding this comment.
Well, almost, there are some other places, where it's gonna break, I will address it after this PR.
mathbunnyru
commented
Jun 20, 2021
|
I don't like makefiles, it is much more simple to run |
mathbunnyru
commented
Jun 20, 2021
| @@ -35,11 +36,10 @@ jobs: | |||
| - name: Build Documentation | |||
| run: make docs | |||
There was a problem hiding this comment.
The idea to keep make docs in the main Makefile is simple - it's an easy way to let users build the docs locally.
They don't need to type sphinx-build command or remember it.
At the same time the process of updating source strings hasn't changed for a looooong time, so let's keep the command here, instead of putting it in Makefile.
consideRatio
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.