Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tensorflow keras bug #1485

Merged
merged 3 commits into from
Oct 16, 2021
Merged

Fix tensorflow keras bug #1485

merged 3 commits into from
Oct 16, 2021

Conversation

mathbunnyru
Copy link
Member

Fix: #1480

mathbunnyru
mathbunnyru commented Oct 16, 2021
View reviewed changes
.pre-commit-config.yaml
@@ -28,6 +28,7 @@ repos:
rev: v2.7.0
hooks:
- id: hadolint-docker
entry: hadolint/hadolint:v2.7.0 hadolint
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the upstream package keeps doing it the wrong way around.
They first make a release and then update the entrypoint.
And we're getting awkward results.

mathbunnyru
mathbunnyru commented Oct 16, 2021
View reviewed changes
r-notebook/Dockerfile
@@ -46,6 +46,7 @@ RUN mamba install --quiet --yes \
fix-permissions "/home/${NB_USER}"

# These packages are not easy to install under arm
# hadolint ignore=SC2039
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this because of hadolint actual update

@mathbunnyru
Copy link
Member Author

Merging without CI, it worked fine on my machine.

@mathbunnyru mathbunnyru merged commit ef5e9dd into jupyter:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mathbunnyru