Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install system packages which are useful for many people #1601

Conversation

mathbunnyru
Copy link
Member

Fix: #1588

@consideRatio
Copy link
Collaborator

consideRatio commented Feb 4, 2022

I appreciate having comments for everything we have included, so that there is clarity for long term maintenance about the purpose/value of all packages.

I cant say if these will be reasonable to remove or not in practice. I'm okay doing it but would appreciate additional reviewers!

@mathbunnyru
Copy link
Member Author

I suppose, if some package is really needed for some crucial feature, we should:

  • docs, why this package is needed, and what feature won't work (inline docs like these help a lot)
  • test, which tests the feature (not just the package)
  • if we delete the package, the users will come with - "hey, this feature doesn't work after the update" and we will add the package back with something from above
  • super-useful package, like wget or vim is also ok

So, in general, I'm not afraid of changes like that :)

Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your thorough work!! ♥️🎉

@mathbunnyru
Copy link
Member Author

Let's merge this, I don't think this will cause us many problems.

@mathbunnyru mathbunnyru merged commit 9cdc605 into jupyter:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The help command doesn't work in notebooks with the R interpreter
2 participants