Run tests in parallel #1624
Merged
Run tests in parallel #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Feb 14, 2022
| def get_host_port(self, container_port: str) -> str: | ||
| """Returns the host port associated with the tracked container's port.""" | ||
| assert isinstance(self.container, Container) | ||
| self.container.reload() |
There was a problem hiding this comment.
This doesn't actually work well when running many tests in parallel :=(
I don't really want to dig in the reason, but I think I've found an implementation, which works more reliable.
romainx
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Hello @mathbunnyru,
Very good initiative 👍. I think we can merge it.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1622
time TEST_IMAGE="jupyter/base-notebook" pytest test/ base-notebook/test/ --log-level debug:Executed in 145.72 secs
Same with
-n auto:Executed in 44.42 secs