Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMP] Disable tests #1675

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Apr 1, 2022

Our CI fails now on any change:
#1672

What happens:
Because of our complicated build system, when we build minimal image, instead of building it on top of just created base image, we end up pulling an old image.
And this happens for other images as well.
And, we also rebuild during push, which is also not great.

This is a major problem.
What I want to do - merge this, rebuild images in master 5 times.
This way all our images eventually will be updated as they were build from source code.

After that, testing cab be enabled back.

@mathbunnyru
Copy link
Member Author

I know this sounds crazy, but I don't see how to fix our broken CI now without some hotfix like this.

@mathbunnyru
Copy link
Member Author

The reason why CI fails:

Jinja2 has changed the import locations of Markup and escape:
Markup and escape should be imported from MarkupSafe.:
https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0

nbconvert already fixed it:
https://github.com/jupyter/nbconvert/pull/1737/files

And the latest version with the fix is available: https://anaconda.org/conda-forge/nbconvert/files

But I think because of how we build images we end up with incompatible packages.

@mathbunnyru
Copy link
Member Author

Merging this one, because it affects all the PRs and makes life much more difficult.
I will manually trigger the workflow several times (each time waiting for the previous one to finish).
After that, I will try to reenable testing.

@mathbunnyru mathbunnyru merged commit c6f0aa1 into jupyter:master Apr 1, 2022
mathbunnyru added a commit to mathbunnyru/docker-stacks that referenced this pull request Apr 2, 2022
mathbunnyru added a commit that referenced this pull request Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant