Update docker_healthcheck.py #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not (always) work. Sometimes, other JSON files appear in the directory, like this kernel-xxx file jpserver-6.json jpserver-6-open.html kernel-374f4977-29fc-43e0-8a48-231f6980fdab.json changing the glob expression to something like "jpserver*.json" instead of simply "*.json" should solve the problem (at least in my case, I checked with a quick patch on a live container, the healthcheck immediately turned 'healthy' again...)
mathbunnyru
reviewed
Mar 3, 2023
|
Thank you for this PR @finalstate. |
|
When we use |
'server-.json' ? this starts to become messy :-) Sorry, I am completely new to this project, so I am not of great help... |
|
It's gonna be It's nice that @imiro added so many test cases, so we can spot bugs like this. |
kentwait
pushed a commit
to kentwait/docker-stacks
that referenced
this pull request
Aug 3, 2023
* Update docker_healthcheck.py This does not (always) work. Sometimes, other JSON files appear in the directory, like this kernel-xxx file jpserver-6.json jpserver-6-open.html kernel-374f4977-29fc-43e0-8a48-231f6980fdab.json changing the glob expression to something like "jpserver*.json" instead of simply "*.json" should solve the problem (at least in my case, I checked with a quick patch on a live container, the healthcheck immediately turned 'healthy' again...) * Update base-notebook/docker_healthcheck.py * Update docker_healthcheck.py --------- Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not (always) work. Sometimes, other JSON files appear in the directory, like this kernel-xxx file
jpserver-6.json
jpserver-6-open.html
kernel-374f4977-29fc-43e0-8a48-231f6980fdab.json
changing the glob expression to something like "jpserver*.json" instead of simply "*.json" should solve the problem (at least in my case, I checked with a quick patch on a live container, the healthcheck immediately turned 'healthy' again...)
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)