Fix applying tags in local development #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Jul 7, 2023
Comment on lines
+72
to
+73
| python3 -m tagging.write_manifest --short-image-name "$(notdir $@)" --hist-line-dir /tmp/jupyter/hist_lines/ --manifest-dir /tmp/jupyter/manifests/ --owner "$(OWNER)" && \ | ||
| python3 -m tagging.apply_tags --short-image-name "$(notdir $@)" --tags-dir /tmp/jupyter/tags/ --platform "$(shell uname -m)" --owner "$(OWNER)" |
There was a problem hiding this comment.
@twalcari the order is important here, because apply_tags removes latest tag, when write_manifest needs it.
mathbunnyru
commented
Jul 7, 2023
| @@ -64,5 +66,6 @@ def apply_tags( | |||
| help="Owner of the image", | |||
| ) | |||
| args = arg_parser.parse_args() | |||
| args.platform = unify_aarch64(args.platform) | |||
There was a problem hiding this comment.
M1/M2 Macs return arm64 (and not aarch64 as Linux), and I work on Mac, so I fixed this as well.
kentwait
pushed a commit
to kentwait/docker-stacks
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)