-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically install latest julia version #2046
Conversation
@yuvipanda @benz0li please take a look. |
|
This looks good to me, but what do you think about rewriting this script in python instead? That would allow us to not use jq. I love jq too, but I always find complex bash gets out of hand fast. |
Thanks, I will rewrite this script in Python. I might need to use |
@yuvipanda done. If you like the Python implementation, I will get rid of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for rewriting shell scripts in python :) I think that's the way to go, especially if we find ourselves parsing JSON.
Can you add even a simple docstring to all the functions? I find that helps tremendously to both clarity when reading as well as in keeping them well scoped during modification.
I understand the desire to use plumbum
, but I find it pretty difficult to read and understand, especially because it's overriding array syntax for command execution. One of the big reasons for me for writing things in python over bash is that it makes it much easier for newer contributors to onboard and make contributions, and I think plumbum sort of turns python into a hybrid shell situation that makes it a little difficult. So I do have a strong preference for just using subprocess
, especially when there's no piping or complex shell-like things involved. Here, we're only using it to call subprocesses and nothing else (as far as I can tell). So what do you think about dropping plumbum and just using subprocess
, with the line being 'are we only calling a process, getting its output (optional)? If so, use subprocess
, else can use plumbum
'.
@yuvipanda done, please, take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay this is awesome! There's one missing docstring, but otherwise this looks good to go.
Pleasure working with you, @mathbunnyru
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)