Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in background #2053

Closed
wants to merge 10 commits into from
Closed

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Idea from: #1909

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru mathbunnyru changed the title Try to run tests in background [FAST_BUILD] Try to run tests in background Dec 8, 2023
@mathbunnyru mathbunnyru closed this Dec 8, 2023
@mathbunnyru mathbunnyru reopened this Dec 8, 2023
@mathbunnyru mathbunnyru changed the title [FAST_BUILD] Try to run tests in background Try to run tests in background Dec 8, 2023
@mathbunnyru mathbunnyru changed the title Try to run tests in background Run tests in background Dec 9, 2023
Comment on lines +5 to +6
"$@"
echo $? > /tmp/jupyter/tests/rc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is possible to implement inline, so I had to create this simple bash script. If someone knows how to do it better, please, tell me.

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Dec 11, 2023

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Dec 11, 2023

1h 22m 35s is good for 3 1CPU runners.
I will enable one more 1CPU runner and test this.

@mathbunnyru
Copy link
Member Author

Comparing with this: #2059

Doesn't seem to be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant