Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/download-artifact and actions/upload-artifact to v4 #2061

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

I had to update this manually, otherwise, dependabot would create separate PR for each action and one for all workflows. And downloading artifacts that were created from action/upload-artifact@v3 and below are not supported by action/download-artifact@v4.

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Dec 14, 2023

x86_64 base upload went down from 1m23s to 10s
aarch64 base upload went down from 1m39s to 15s

Finally, we get good performance.
Should significantly decrease total CI time.
Obviously, the devs of these actions didn't like my PR: #2059 (this PR only made sense because of slow uploads).

@mathbunnyru
Copy link
Member Author

1h 2m 24s - that's great, merging this one.

@mathbunnyru mathbunnyru merged commit 0736628 into jupyter:main Dec 14, 2023
64 checks passed
mathbunnyru added a commit that referenced this pull request Dec 20, 2023
mathbunnyru added a commit to mathbunnyru/docker-stacks that referenced this pull request Dec 21, 2023
mathbunnyru added a commit to mathbunnyru/docker-stacks that referenced this pull request Jan 7, 2024
mathbunnyru added a commit to mathbunnyru/docker-stacks that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant