-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create apply_tags #998
Create apply_tags #998
Conversation
Draft!
Julia prints a bit more so we make it conformant with the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nosferican Thanks for submitting this. The code you submitted looks right. We don't have any automated testing setup for the docker hub hooks. In lieu of that, could you try running the few new commands that fetch the Julia and R versions locally to ensure they return the expected values?
In addition to this script, you'll need to add a couple lines like these found in base-notebook/hooks/post_push
to the top of datascience-notebook/hooks/post_push
to source the apply_tags
file:
docker-stacks/base-notebook/hooks/post_push
Lines 4 to 6 in 414b5d7
# Apply and push all tags | |
source hooks/apply_tags | |
docker push $DOCKER_REPO |
After confirming the commands work and adding those extra lines, I think this is good to merge and try.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nosferican I think there's a couple copy/paste errors in your last commit. If you accept those two tag name changes, I think we're good to merge.
Co-Authored-By: Peter Parente <parente@gmail.com>
Co-Authored-By: Peter Parente <parente@gmail.com>
@Nosferican Thanks for sending this PR and working through improving it. 🍰 Let's merge it and see how it goes. If there are problems when Docker Hub attempts to build the image, we might need to iterate. I'll comment back here with the results since the build logs are, unfortunately, private. |
I fixed a small error missed during code review with a direct comment to master: 9f4983c#diff-57bd71ca260fa0afd2753f51e94b8420 |
Follow on from jupyter#998
Draft!