Skip to content

Commit

Permalink
typos, add interested parties
Browse files Browse the repository at this point in the history
  • Loading branch information
srl295 committed Jun 10, 2016
1 parent c3026bb commit 33d8288
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ This will be done like this:
<a href="#">{{ _("New Notebook") }}</a>
```

### Javascrip files
### Javascript files

Regarding Javascript we will use the same approach as HTML but we will have to do a few more changes to make sure javascript files get translated before they are sent to the browser. The approach for this is as follows:

Expand Down Expand Up @@ -98,9 +98,10 @@ Pros associated with this implementation include:
* Can be used later with Jupyter Hub to set multiple languages for multi-lingual teams.

Cons associated with this implementation include:
* Javascrip strings and HTML files will have `{{ _(XXX) }}` in the source code.
* Javascript strings and HTML files will have `{{ _(XXX) }}` in the source code.
* A change in the development guide lines to use translation
* Rendering javascript files means you cannot use `{{XXX}}` or `{% X %}` inside any javascript files. This means no [mustache](https://mustache.github.io/) (It is not used now, but it cannot be used in the future).

## Interested Contributors
@twistedhardware @rgbkrk @captainsafia
@twistedhardware @rgbkrk @captainsafia @JCEmmons @srl295

0 comments on commit 33d8288

Please sign in to comment.