Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-incubator/dashboards incorporation proposal #17

Merged
merged 2 commits into from
Jul 18, 2016
Merged

jupyter-incubator/dashboards incorporation proposal #17

merged 2 commits into from
Jul 18, 2016

Conversation

parente
Copy link
Member

@parente parente commented Jun 20, 2016

This PR proposes graduating the dashboard layout extension from jupyter-incubator. Per the roadmap and discussion at the Spring '16 dev meeting, it does not include the other, related projects such as the dashboards server. (We'll follow-on with a proposal for that and others.)

cc'ing folks who commented on the original incubation proposal to start: @vinomaster @rgbkrk @ellisonbg @fperez @Carreau @lbustelo @lmeyerov @minrk @damianavila

(c) Copyright IBM Corp. 2016
@minrk
Copy link
Member

minrk commented Jun 24, 2016

👍

@fperez
Copy link
Member

fperez commented Jun 25, 2016

While eventually I figured out what you meant, I would suggest rewording the first paragraph in the repo README and say something like:

The Jupyter Incubator Dasboards effort covers:

1. ...
2. ...
3. ...

This repository focuses on (1) above, while (2) and (3) are dealt with at ... and ...

I think the current language is a bit ambiguous on first read as to what is the whole effort vs what is covered by this repo.

@parente
Copy link
Member Author

parente commented Jun 25, 2016

@fperez said:

While eventually I figured out what you meant, I would suggest rewording the first paragraph in the repo README and say something like:

Will do. I'll double-check the proposal text too since it includes a similar statement.

I think the current language is a bit ambiguous on first read as to what is the whole effort vs what is covered by this repo.

The curse of multiple repositories strikes again! 😱

parente added a commit to jupyter/dashboards that referenced this pull request Jun 27, 2016
parente added a commit to jupyter/dashboards_bundlers that referenced this pull request Jun 27, 2016
parente added a commit to jupyter/dashboards_server that referenced this pull request Jun 27, 2016
@parente
Copy link
Member Author

parente commented Jul 18, 2016

@fperez With @willingc 's help, we've stood up a RTD site with documentation about how to install, use, and develop the dashboards extension.

https://jupyter-dashboards-layout.readthedocs.io

I think it addresses the concern about projects needing doc before leaving the incubator from our conversation on the 2016-07-05 stand-up. I'll update this PR to refer to the site accordingly.

(c) Copyright IBM Corp. 2016
@willingc willingc merged commit f5e8555 into jupyter:master Jul 18, 2016
@parente
Copy link
Member Author

parente commented Jul 18, 2016

@willingc did you mean to merge the proposal?

@willingc
Copy link
Member

@parente Nope. Too early here. I was thinking this PR was just the docs. I reverted the merge but that may have messed the history up.

FWIW, it would be great to graduate this project ;-)

Sorry for the confusion.

@parente
Copy link
Member Author

parente commented Jul 18, 2016

@willingc No problem. Can you reopen this pull request though so I don't have to submit a new one? I don't have permissions to reopen it myself.

@rgbkrk
Copy link
Member

rgbkrk commented Jul 18, 2016

I don't see a way to reopen a PR here, only a way to revert.

@parente
Copy link
Member Author

parente commented Jul 18, 2016

I don't see a way to reopen a PR here, only a way to revert.

I guess once you merge, you can't reopen. You can only reopen if you close without merging. Maybe.

@rgbkrk
Copy link
Member

rgbkrk commented Jul 18, 2016

There might be an API way. Otherwise, we would probably need to open yet another PR with your current branch. :(

@willingc
Copy link
Member

Sorry again :(

@parente
Copy link
Member Author

parente commented Jul 18, 2016

@willingc Not a problem, really. New PR is #20.

@willingc
Copy link
Member

Thanks @parente.

parente added a commit to jupyter/dashboards_bundlers that referenced this pull request Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants