Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the commit hooks list #268

Merged
merged 7 commits into from
Jan 10, 2024
Merged

chore: update the commit hooks list #268

merged 7 commits into from
Jan 10, 2024

Conversation

12rambau
Copy link
Contributor

As mentioned in #237, I updated the list of pre-commit to something more comfortable.

The new list is more restricted and cover pretty much the same things as many were overlapping:

  • black for the python file linting (I just aligned the line length to ruff at 100 characters)
  • prettier for anything else (json and yaml schema are tested as well for parsing purposes)
  • nbstripout because we have notebooks
  • doc8 (maybe not the best choice but the only one I know for Sphinx checks)
  • ruff, the ligthning fast swiss army knife PEP checker

I also change the lint hatch session so it run the exact same thing as the one in the test suit.

I was forced to add some ignore in ruff for documentation issues.

@12rambau 12rambau marked this pull request as ready for review December 29, 2023 19:26
@12rambau 12rambau marked this pull request as draft December 29, 2023 19:28
@12rambau 12rambau requested a review from akhmerov January 9, 2024 16:26
tests/test_execute.py Outdated Show resolved Hide resolved
jupyter_sphinx/execute.py Outdated Show resolved Hide resolved
12rambau and others added 2 commits January 10, 2024 06:29
Co-authored-by: Anton Akhmerov <anton.akhmerov@gmail.com>
@12rambau 12rambau marked this pull request as ready for review January 10, 2024 06:31
@12rambau 12rambau marked this pull request as draft January 10, 2024 06:34
@12rambau 12rambau marked this pull request as ready for review January 10, 2024 09:02
@12rambau 12rambau merged commit 7bd1b03 into main Jan 10, 2024
10 checks passed
@12rambau 12rambau deleted the pre-commit branch January 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants