Skip to content

Commit

Permalink
Remove some deprecated zmq imports
Browse files Browse the repository at this point in the history
The zmq.eventloop.ioloop shim has been deprecated since pyzmq 17
  • Loading branch information
minrk committed Sep 29, 2022
1 parent ee4bbc4 commit 9233c85
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion jupyter_client/ioloop/restarter.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def _loop_default(self):
DeprecationWarning,
stacklevel=4,
)
from zmq.eventloop import ioloop
from tornado import ioloop

return ioloop.IOLoop.current()

Expand Down
2 changes: 1 addition & 1 deletion jupyter_client/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
from typing import Union

import zmq
from tornado.ioloop import IOLoop
from traitlets import Any
from traitlets import Bool
from traitlets import CBytes
Expand All @@ -46,7 +47,6 @@
from traitlets.config.configurable import LoggingConfigurable
from traitlets.log import get_logger
from traitlets.utils.importstring import import_item
from zmq.eventloop.ioloop import IOLoop
from zmq.eventloop.zmqstream import ZMQStream

from jupyter_client import protocol_version
Expand Down
4 changes: 2 additions & 2 deletions jupyter_client/threaded.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
from typing import Union

import zmq
from tornado import ioloop
from traitlets import Instance
from traitlets import Type
from zmq import ZMQError
from zmq.eventloop import ioloop
from zmq.eventloop import zmqstream

from .session import Session
Expand Down Expand Up @@ -47,7 +47,7 @@ def __init__(
self,
socket: Optional[zmq.Socket],
session: Optional[Session],
loop: Optional[zmq.eventloop.ioloop.ZMQIOLoop],
loop: Optional[ioloop.IOLoop],
) -> None:
"""Create a channel.
Expand Down

0 comments on commit 9233c85

Please sign in to comment.