Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.0.0 breaks qtconsole #523

Closed
frmdstryr opened this issue Feb 27, 2020 · 9 comments · Fixed by ipython/ipykernel#489
Closed

Version 6.0.0 breaks qtconsole #523

frmdstryr opened this issue Feb 27, 2020 · 9 comments · Fixed by ipython/ipykernel#489
Labels

Comments

@frmdstryr
Copy link

ipykernel's InProcessKernelClient used by qtconsole does not use a control_channel. (see https://github.com/ipython/ipykernel/blob/master/ipykernel/inprocess/client.py#L45)

Version 6.0.0 assumes every client uses this channel and attempts to create a channel using the abstract ControlABC class which throws the error in #270 (hence the new comments).

See inkcut/inkcut#231 (comment) for a Traceback

@MSeal
Copy link
Contributor

MSeal commented Feb 28, 2020

Thanks for raising, I see the change involved. I'll look at making a fix soon.

@luiztauffer
Copy link

Found the same problem when using qtconsole with jupyter-client-6.0.0.
No error with jupyter-client-5.3.4

@davidbrochart
Copy link
Member

The control channel was introduced in KernelClient here: 5ad166c
I'm not sure it is now mandatory for clients to use this channel, or if we should fall back to the shell channel if not.

@3fon3fonov
Copy link

I can confirm this bug. Any solutions?

3fon3fonov/exostriker#55

Thanks!

@davidbrochart
Copy link
Member

ipython/ipykernel#489 should fix it.

@frmdstryr
Copy link
Author

Thanks!

@luiztauffer
Copy link

luiztauffer commented Mar 21, 2020

Is #523 expected to be included in any release soon?
The latest release 6.1.0 doesn't seem to have included the solution

@MSeal
Copy link
Contributor

MSeal commented Mar 21, 2020

Read the link above, it's waiting on an ipykernel release not a jupyter_client release.

@davidbrochart
Copy link
Member

FYI, ipykernel v5.2.0 has been released: https://github.com/ipython/ipykernel/releases/tag/5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants