Expose control channel on AsyncKernelManager #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thank you for the merge David. I'm hoping we can talk about cutting a 6.1.0 release for the async kernel management stuff, but before that, I'd like to finish reviving related PRs from yesteryear in notebook and enterprise_gateway in case they require changes here. I plan to have these completed by EOD Friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviving the async kernel management work in Notebook after #428 was merged, I ran into an issue with the control socket since I hadn't applied the ioloop manager portion of #447 to the AsyncIOLoopKernelManager. This change adds the appropriate
as_zmqstreamentry to the kernel manager and the Notebook issue is no longer present.