Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] [Resource Leak] Gracefully Close ZMQ Context upon kernel shutdown #548

Merged
merged 14 commits into from
Jun 22, 2020
Merged

[BugFix] [Resource Leak] Gracefully Close ZMQ Context upon kernel shutdown #548

merged 14 commits into from
Jun 22, 2020

Commits on May 24, 2020

  1. [BugFix] Close ZMQ Context upon kernel shutdown 

    During kernel startup we create new context of ZMQ.
However during kernel shutdown we are not shuting down ZMQ context
This leads to leaks of ZMQ reaper sockets.
    Jalpan Randeri committed May 24, 2020
    Configuration menu
    Copy the full SHA
    3e1436f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. cr feedback move to cleanup method

    Jalpan Randeri committed May 25, 2020
    Configuration menu
    Copy the full SHA
    de91042 View commit details
    Browse the repository at this point in the history

  2. changes to cleanup method in multikernel manager

    Jalpan Randeri committed May 25, 2020
    Configuration menu
    Copy the full SHA
    02f3c50 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. cr feedback b/c change

    Jalpan Randeri committed May 26, 2020
    Configuration menu
    Copy the full SHA
    508589c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. pick correct cleanup method based on version

    Jalpan Randeri committed May 27, 2020
    Configuration menu
    Copy the full SHA
    5d06e0c View commit details
    Browse the repository at this point in the history

  2. add new cleanup_resources method in multikernel

    Jalpan Randeri committed May 27, 2020
    Configuration menu
    Copy the full SHA
    8a90e25 View commit details
    Browse the repository at this point in the history

  3. update cleanup logic in multikernel manager

    Jalpan Randeri committed May 27, 2020
    Configuration menu
    Copy the full SHA
    05d4f6d View commit details
    Browse the repository at this point in the history

  4. update kernelapp with new cleanup_resources method

    Jalpan Randeri committed May 27, 2020
    Configuration menu
    Copy the full SHA
    a6cae07 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. context destory must happen after socket closing

    Jalpan Randeri committed May 28, 2020
    Configuration menu
    Copy the full SHA
    29bb6cb View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. move cleanup at bottom

    Jalpan Randeri committed May 29, 2020
    Configuration menu
    Copy the full SHA
    6d99486 View commit details
    Browse the repository at this point in the history

  2. shared context protection

    Jalpan Randeri committed May 29, 2020
    Configuration menu
    Copy the full SHA
    f0dbfa9 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. cherry-pick from @minrk work on sharing context by default 

    jupyter@4cdbf54
    Jalpan Randeri committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    2d5ba4b View commit details
    Browse the repository at this point in the history

  2. handle case when del is not availiable in parent

    Jalpan Randeri committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1ce1d97 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. change warning class to FutureWarning

    Jalpan Randeri committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9c0ef5d View commit details
    Browse the repository at this point in the history