Fallback to the old ipykernel "json_clean" if we are not able to serialize a JSON message #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
fallback_json_clean
branch
from
f4b3ce3
to
56a6ec9
Compare
serialize a JSON message
martinRenou
force-pushed
the
fallback_json_clean
branch
from
56a6ec9
to
9ea8ce1
Compare
minrk
reviewed
Oct 1, 2021
Co-authored-by: Min RK <benjaminrk@gmail.com>
|
Thanks a lot for the review @minrk |
|
Great, thanks! |
|
@davidbrochart do you want to try an automated release with this change? |
|
Sure, but maybe a bit later. |
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #706 (comment)
Fix jupyter-widgets/pythreejs#366 and fix #701