Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct usage of tornado #997

Closed
wants to merge 50 commits into from

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 18, 2023

See jupyter-server/jupyter_server#1362 for discussion. This will require a major version change since the loops are public properties.

  • Make the app use asyncio.main
  • Move the get_event_loop function to jupyter_core (renamed to ensure_event_loop)
  • Get unit tests passing
  • Get downstreams passing
  • Document changes in migration guide

@blink1073

This comment was marked as outdated.

@blink1073 blink1073 marked this pull request as ready for review December 10, 2023 14:25
@blink1073 blink1073 marked this pull request as draft December 10, 2023 14:25
@blink1073 blink1073 changed the title Remove tornado and zmqstream Remove direct usage of tornado Feb 18, 2024
@blink1073 blink1073 closed this Aug 24, 2024
@blink1073 blink1073 deleted the remove-zmqstream branch August 24, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant